hubverse-org / hubEnsemblesManuscript

https://htmlpreview.github.io/?https://github.com/Infectious-Disease-Modeling-Hubs/hubEnsemblesManuscript/blob/master/analysis/paper/hubEnsembles_manuscript.html
Other
1 stars 2 forks source link

language around cdf aggregation in linear pools #51

Closed elray1 closed 3 months ago

elray1 commented 3 months ago

very minor comment on this text:

In other words, for a set of CDFs, $\mathcal{F} = \{F_i(x)| i \in 1,...,N \}$ and weights, $\pmb{w}$, the linear pool is calculated as

$$ F{LOP}(x) = C{LOP}(\mathcal{F}, \pmb{w}) = \sum_{i = 1}^Nw_iF_i(x). $$

I can phrase this comment in two ways:

Probably easiest to address this by updating the first sentence to something like "In other words, for a set $\mathcal{F} = \{F_i(x)| i \in 1,...,N \}$ of CDFs evaluated at the point $x$, and weights..." (open to other variations/phrasings of this -- trying to get to the idea that what's in the set are values of cdfs at a point, not the cdf functions themselves)

elray1 commented 3 months ago

same comment applies just below when describing the setup with pmfs too

elray1 commented 3 months ago

i'll put in a pr that includes this update