Given that this review arrives so closely to the limit date, I figured I would send my comments as a PR and hopefully save you a bit of time.
Feel free to push directly to this branch, and cherry-pick specific commits if necessary or if you disagree with specific changes.
542e280f39aef851b5e1e2928d4a7cb7afd1ae15 ensures consistency in the function format, and uses the format recommended by the tidyverse style guide.
d6f131e7ddb46794f10f48549dd26729bbae7416 explains how sample output can still be used indirectly, just the extra steps of converting it to another type
1a1677cc566a58610431757242c777c4c12baa0f may be the most nitpicky change of all. It's probably slightly better practice to pass functions as function objects, rather than strings. In fact, R Core has been making changes in this direction recently (source). I would maybe go as far as potentially disallowing strings entirely in agg_fun but a much less controversial change is to stick to functions in examples to encourage good practice.
Given that this review arrives so closely to the limit date, I figured I would send my comments as a PR and hopefully save you a bit of time.
Feel free to push directly to this branch, and cherry-pick specific commits if necessary or if you disagree with specific changes.
agg_funbut a much less controversial change is to stick to functions in examples to encourage good practice.