Will be based on comparisons to the output of hubUtils::expand_model_out_val_grid()
Some initial discussion in a hubUtils PR.
Validation, this will happen in two steps.
[x] 1. Ensure all combinations of required values present:
When we are validating required values, we are only interested in the columns that actually have required values. So we will use the output of expand_model_out_val_grid(..., required_vals_only = TRUE) to ensure that the submission file contains all required combinations across appropriate columns.
[x] 2. Ensure submission values represent valid combinations of accepted values (optional + required)
This check will now compare the submission file to the full combinations of values and ensure the file either matches the output of expand_model_out_val_grid() or is a subset of it. In this check, all columns are involved (as optional values are included in the expanded grid) and we also ensure all combinations of values in the submission file are unique at this stage.
Having said that, I will likely include a simpler validation test before these to check whether all expected columns for the round are present anyways.
Will be based on comparisons to the output of
hubUtils::expand_model_out_val_grid()Some initial discussion in a
hubUtilsPR.Validation, this will happen in two steps.
expand_model_out_val_grid(..., required_vals_only = TRUE)to ensure that the submission file contains all required combinations across appropriate columns.expand_model_out_val_grid()or is a subset of it. In this check, all columns are involved (as optional values are included in the expanded grid) and we also ensure all combinations of values in the submission file are unique at this stage.Having said that, I will likely include a simpler validation test before these to check whether all expected columns for the round are present anyways.
_Originally posted by @annakrystalli in https://github.com/Infectious-Disease-Modeling-Hubs/hubUtils/pull/86#discussion_r1254034701_