search

hubverse-org / hubValidations

Testing framework for hubverse hub validations
https://hubverse-org.github.io/hubValidations/
Other
1 stars 4 forks source link

Fix required vals check bug #124

Closed annakrystalli closed 1 month ago

annakrystalli commented 1 month ago

The bug is described in #123 and solved partly by @zkamvar 's suggestion in the issue.

Fixed fully by differentiating behaviour of expand_model_out_grid() when required_vals are requested and all output types are optional and when required_vals are requested for subsets of output types.

Added detailed comment in code that explains the reasoning.

Also added a small nowcast example hub.

Note I've incremented the version number for tracking of this bug.

github-actions[bot] commented 1 month ago

🚀 Deployed on https://66fea892d9202cb0a8db0560--hubvalidations-pr-previews.netlify.app

annakrystalli commented 1 month ago

Thanks @zkamvar .

I've committed, updated the snapshots and add the new tests. Will merge when tests pass

zkamvar commented 1 month ago

I've committed, updated the snapshots and add the new tests. Will merge when tests pass

🙈 I forgot that the snapshot tests depend on the title of the test