initial start on validation for model metadata

elray1 commented 1 year ago

first bit of functionality, much of it untested so far. not really ready for review.

elray1 commented 1 year ago

Pull request is now ready for review. This is to address issue #7

annakrystalli commented 1 year ago

So I've:

merged my original MVP PR into main and directed this PR to main
corrected the merge conflict that had arisen
fixed some missing dependencies in DESCRIPTION flagged by R CMD CHECK and removed unnecessary function imports (as more explicit :: namespacing was already being used)
Added custom function capacity to validate_model_metadata()
Made some minor edits, in particular added a get_metadata_file_name() utlis function for getting the metadata filename from a model output data file path and renamed check_metadata_file_exists_for_output_submission() to check_submission_metadata_file_exists() to make it a bit more concise.

CI now running on this PR and all checks are passing.

My only question is in the review comment.

hubverse-org / hubValidations