Closed annakrystalli closed 1 year ago
Additional relevant discussion
Right, I also wasn't totally clear about this but basically landed in a similar place to where you did:
model-output
would have validate_model_file
run on it, which also checks for the existence of a corresponding model metadata file but doesn't actually validate that model metadata file's contents. For these checks, the file_path
is relative to model-output
.model-metadata
would have validate_model_metadata
run on it. For these checks, the file_path
is relative to model-metadata
.
validate_model_metadata
and let this check verify that they're in the right placemodel-output
or model-metadata
". This strategy hasn't always been great (we've had an occasional accidental merge of files in unexpected locations because the PR validations didn't fail)._Originally posted by @elray1 in https://github.com/Infectious-Disease-Modeling-Hubs/hubValidations/pull/21#discussion_r1327483993_
Any file submitted to locations other than
model-output
ormodel-metadata
is not validated byvalidate_pr()
,Add a message pops up on the pull request saying something like, "this pull request includes one or more files that are in a location other than model-output or model-metadata", as is done in the US covid hub. (@elray1 if there's some relevant code for this, feel free to add a link although I imagine it's in python?)