hubverse-org / hubValidations

Testing framework for hubverse hub validations
https://hubverse-org.github.io/hubValidations/
Other
1 stars 4 forks source link

Consider using hubUtils::model_id_merge for merging model_id #36

Open elray1 opened 1 year ago

elray1 commented 1 year ago

In this code, we do some stuff related to merging team_abbr and model_abbr to get a model_id, but it's not as careful as what is done in hubUtils::model_id_merge. I think that function from hubUtils could almost work for our purposes here as-is, except that it currently expects a data frame (and has some indexing that is dataframe-specific), while here we just have a list. We could convert to a data frame or make some minor tweaks to the hubUtils function?