hubverse-org / hubValidations

Testing framework for hubverse hub validations
https://hubverse-org.github.io/hubValidations/
Other
1 stars 3 forks source link

Include option to print results of all checks in `check_for_errors` #49

Closed annakrystalli closed 9 months ago

annakrystalli commented 9 months ago

Currently output of check_for_errors either prints a single ✔ if all checks pass or the output of only failing checks if any fail.

Include a verbose option that prints the result of all checks prior to the summary.

annakrystalli commented 9 months ago

How does this look for a verbose output @nickreich @rborchering @elray1 ?

── Individual check results ──

✔ FluSight-forecast-hub: All hub config files are valid.
✔ 2023-10-14-UMass-trends_ensemble.csv: File exists at path
  model-output/UMass-trends_ensemble/2023-10-14-UMass-trends_ensemble.csv.
✔ 2023-10-14-UMass-trends_ensemble.csv: File name "2023-10-14-UMass-trends_ensemble.csv" is valid.
✔ 2023-10-14-UMass-trends_ensemble.csv: File directory name matches `model_id` metadata in file name.
✔ 2023-10-14-UMass-trends_ensemble.csv: `round_id` is valid.
✔ 2023-10-14-UMass-trends_ensemble.csv: File is accepted hub format.
✖ 2023-10-14-UMass-trends_ensemble.csv: Metadata file does not exist at path
  model-metadata/UMass-trends_ensemble.yml or model-metadata/UMass-trends_ensemble.yaml.

── Overall validation result ──────────────────────────────────────────────────────────────────────────────
✖ 2023-10-14-UMass-trends_ensemble.csv: Metadata file does not exist at path
  model-metadata/UMass-trends_ensemble.yml or model-metadata/UMass-trends_ensemble.yaml.
Error in `check_for_errors()`:
! 
The validation checks produced some failures/errors reported above.
Run `rlang::last_trace()` to see where the error occurred.
nickreich commented 9 months ago

I like it!

elray1 commented 9 months ago

agree :)