change valid output_type to "pmf" from "categorical"

hubverse-org / schemas

JSON schemas for modeling hubs

Creative Commons Zero v1.0 Universal

4 stars 2 forks source link

change valid output_type to "pmf" from "categorical" #35

Closed nickreich closed 1 year ago

nickreich commented 1 year ago

Is this worth doing? It feels semantically a bit better. As the output is a category, not a categorical.

annakrystalli commented 1 year ago

Personally given the breaking nature of the change, I would prefer to keep it as categorical. Personally it makes sense semantically as the type of output is categorical.

nickreich commented 1 year ago

Noting that we made this decision to align the description of the current "categorical" or "category" type_id with what is specified currently as "cdf":