hubverse-org / schemas

JSON schemas for modeling hubs
Creative Commons Zero v1.0 Universal
4 stars 2 forks source link

nomenclature about `type`, `output_type`, and `target_type` #49

Closed elray1 closed 1 year ago

elray1 commented 1 year ago

Currently in the hub tasks.json, we have:

  1. model_tasks > output_type, which describes a representation or summary of a probability distribution and lines up with the type column in a model output submission file
  2. model_tasks > target_metadata > target_type, which describes a statistical variable type

Maybe we should have a more consistent naming for the two things in point 1? e.g., might we want to change the column name in submission files to output_type rather than just type?

annakrystalli commented 1 year ago

Happy with this and makes sense to me.

Let me know whether to go ahead and implement .

Main changes required will be to:

annakrystalli commented 1 year ago

This is complete in hubUtils. Still needs addressing in hubDocs but issue exists: https://github.com/Infectious-Disease-Modeling-Hubs/hubDocs/issues/50.

Closing here