search

hubverse-org / schemas

JSON schemas for modeling hubs
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

remove epidemic week formatting requirements for CDF category values #80

Closed elray1 closed 4 months ago

elray1 commented 5 months ago

I just noticed that the schema requires that the CDF values are either numeric or are strings in the format of an epidemic week, e.g. "EW202204". I don't think there's a reason to impose this formatting requirement, though -- one could imagine collecting CDF predictions for an ordinal categorical variable other than epidemic weeks with strings naming the categories that don't match that format.

For example, looking here: https://github.com/Infectious-Disease-Modeling-Hubs/schemas/blob/2e79b13d309168824bcca7ef716ebeb9aa3cda44/v3.0.0/tasks-schema.json#L948-L953

annakrystalli commented 4 months ago

Quick question, we want min and max removed also right? https://github.com/hubverse-org/schemas/blob/2e79b13d309168824bcca7ef716ebeb9aa3cda44/v3.0.0/tasks-schema.json#L951-L952

elray1 commented 4 months ago

yeah, i agree that it makes sense to remove those too