Closed jsperhac closed 1 year ago
Mistakenly included core/components/com_resources/helpers/html.php in this commit.
Note that Nick's fix presently resides on prod, and I pulled the changes into a separate branch there ('sso-user-email-address').
Once this PR is approved and merged to 'dev', we'll need to push the 'dev' branch to prod and ensure that branch is made active.
Removed core/components/com_resources/helpers/html.php from this PR. This is now just the fix for USP-76.
Summary
Signing on to the USP test IdP runs properly and redirects user to the USP Hub.
However, if the user declined to link their SSO account to an existing local Hub account, they were prompted for a valid email address. We have “update on next” set 'read only', so no email address is displayed or editable. User is stuck at members/update and unable to complete registration.
Registration should accept the USP provided email address for the new account.
Fix performed by @nkissebe
Please see Jira card here: https://sdx-sdsc.atlassian.net/browse/USP-76
Testing
Parameters are:
Three cases while signing in as a USP SSO user are now working as expected:
as USP SSO user zzz: no, have never logged in before if username collision, must change username success, account is marked as approved. This works correctly.
as USP SSO user yyy: yes, have logged in before decline to link accounts if username collision, must change username success, account is automatically approved. This works correctly.
as USP SSO user xxx: yes, have logged in before attempt to link accounts prompted to sign in as existing Hub account, first on successful sign-in, SSO and local accounts are linked can view specifics in user's profile page, password detail