search

hubzero / hubzero-cms

Platform for Scientific Collaboration
https://hubzero.org
GNU General Public License v2.0
46 stars 57 forks source link

Fix de id order #1645

Closed jessewoo closed 1 year ago

jessewoo commented 1 year ago

Can't rely on the order the plugin runs in, so should set the deletion profile key in the controller before calling the plugins, and unset the key after the plugin is ran. Should move the last database updates where we update the field user records until after all plugins run. Should also check plugin returns, shouldn't run the final deletion if any of the plugins fail.

dbenham commented 1 year ago

Does this need to be in 2.2.26?

jessewoo commented 1 year ago

Hi @dbenham - I think it needs to be with 2.2.26 because it goes with the de-id feature

jessewoo commented 1 year ago

@dbenham - wondering if you could merge it because it has to do with de-id feature that is rolled into 2.2.26?

dbenham commented 1 year ago

Merged into dev and cherry picked into 2.2.26