[PURR-125] anonymous ftp workflow - 2 download buttons

hubzero / hubzero-cms

Platform for Scientific Collaboration

https://hubzero.org

GNU General Public License v2.0

46 stars 57 forks source link

[PURR-125] anonymous ftp workflow - 2 download buttons #1652

Closed JackS9 closed 10 months ago

JackS9 commented 1 year ago

JIRA task: https://sdx-sdsc.atlassian.net/browse/PURR-125
Support ticket: https://purr.purdue.edu/support/ticket/2383
PURR core addition: 8 - anonymous ftp workflow
Summary of Issue: Popular browsers stopped supporting anonymous FTP. Instead, a popup dialog is presented to download an FTP client, which is not convenient. Pascal made backend changes to apache to transfer file via https, and now we need two download buttons to support both types of download.
Summary of Fix/Changes: Created two download buttons: one for HTTPS and another for FTP.
Summary of Testing: Testing done by PURR staff on their dev environment. This will be tested again on PURR production hub by PURR staff.
Hotfix needed? This will be pulled to PURR prod as part of testing and targeted for next CMS release (2.2.27)

NOTE: This update contains a migration, but it only provides a default value for param field.

nkissebe commented 1 year ago

Also I don't think we even support ftp at all, regardless of browser support. There might be sftp support but that couldn't really be a button. Maybe a little pop-up to give sftp instructions or something

JackS9 commented 1 year ago

General comment about these PURR Core Additions: This first pass of PRs is to push the code “as is” from the developer (primarily Jerry Kuang). After that, I can then attempt to fix or make changes based on reviewer comments. However, I think we need to bring the original developer (and others) into the loop if the original issue and/or approach to resolving it are in question.
Also, my dev environment is not currently set up to test many PURR-related operations - I.e., no real publications or resources, no DOI setup, no curators, no FTP setup, etc. So some of the suggested changes may need to be developed and tested on dev.purr.purdue.edu first.

dbenham commented 1 year ago

I believe the issue is not specific to PURR, but it will need to be reworked in order to be put into core. We could consider pointing the button to a page on help.hubzero.org.

dbenham commented 10 months ago

I'm going to close the PR out once @kuang5 has had a chance to recreate it in his name. Then we can use the new PR to address issues going forward. I sent @kuang5 a direct email just now outlining this plan.

dbenham commented 10 months ago

Superceeded by PR 1689. Created new PR so Jerry would own the PR instead of Jack (who is no longer with us). I will transfer feedback from this PR to 1689, and once I do, I will close this one out.