Closed dbenham closed 9 months ago
Yeah this needs some work, but the changes are in the same style it was originally in and if you say it works better then so be it. I would review the use multistep commands in shell_exec() and the use of echo "" inside of <?php rather than just using <?= to display variables inside of straight html. But both of these cases were in the original code so should not block this PR.
Overall, this component needs some major refactoring. It is way over architected. But these fixes should get it up and running for now.