search

hubzero / hubzero-cms

Platform for Scientific Collaboration
https://hubzero.org
GNU General Public License v2.0
47 stars 57 forks source link

[PURR-149] - string conversion not handled properly #1688

Closed dbenham closed 8 months ago

dbenham commented 9 months ago

https://purr.purdue.edu/support/ticket/2482 - original ticket

Looks like an untested quote fix from an earlier change. A php string conversion issue. Reworked the SQL statement being built not to use embedded string variables inside a double quoted string. Made the code match what was in the rest of the file.

Got a pretty good write up in the Jira card on reproducing. Easily able to reproduce error, make fix, and observe fix.

There were two other fixes made in dev that were added to this as well that were not part of the original ticket, they followed the convention in the file, so changes were not needed for these.

No hotfix needed, part of the 2.2.27 build

dbenham commented 9 months ago

@nkissebe - Need you to approve, I can't assign myself as a reviewer, and I do not want to uncheck "require approvals" for the dev branch. And as far as I can tell, github does not allow you to add yourself as a reviewer of your own pull request.

dbenham commented 8 months ago

closing this PR, I totally messed up the merge with another commit, I'm just going to start over.