hubzero / hubzero-cms

Platform for Scientific Collaboration
https://hubzero.org
GNU General Public License v2.0
47 stars 57 forks source link

[PURR-125] anonymous ftp workflow - 2 download buttons #1689

Closed kuang5 closed 7 months ago

kuang5 commented 9 months ago
dbenham commented 9 months ago

Jerry,

High level question. Is there any reason using just https downloads for these won't work? What are the typical file sizes download via this link? We can adjust php settings if timeouts are an issue.

dbenham commented 9 months ago

In it's current form, this cannot go forward into core. Three options I see:

1) reduce the help document to a javascript popup or tool tip of several sentences, so instructions can easily be included in the interface instead of a separate document

2) If the help document is a requirement, the document referred to in this fix needs to be created (in it's entirety) via the migration script, so that when this change is sent to other hubs, the document follows it. I'm not sure this is easily done, as the current help document has inline images and a structure that would be a challenge to create via a script, so I'm not even sure if this is a viable option. Using a link so that all hubs point to a centrally located document file is not a viable option, there is no way to ensure the target link exists.

3) Remove FTP functionality altogether and modify php as needed to support larger downloads via https. i.e. adjust timeouts and memory requirements for the page doing the streaming download.

I'd like to pursue #3, with #1 as a backup option if it turns out file sizes make this option unusable.

kuang5 commented 9 months ago

Hi Dave,

I accept reducing the help document to a few sentences are good. How about tooltips "Please choose a FTP client such as FileZilla or WinSCP that may be already installed on your computer to download the dataset. For more details look for 'ftp' article in KB"?

We use the anonymous ftp function a lot for both us and users, not only for downloading but also for transferring files to PURR which are going to be imported in project. Please let us know if you plan to disable the function and we need to find out other solution for such kind of use case.

Regarding download large files through https, I'm not sure whether that works for large files, such as the largest dataset on PURR is over 200GB so far, and I think there will be more larger dataset that are going to be published on PURR in the future.

Jerry

dbenham commented 7 months ago

@kuang5 I decided not to include this feature in core, after discussing with the team, we didn't think there was any real limitation to using https. We regularly download large files on other hubs. If we run into any size problems going forward, we're pretty confident we can get around those by tweaking site php settings.

However, If you want to continue to give PURR this in the interface, you'll have to include it in a custom component. We can talk about the details sometime if you like. The override should be fairly simple.