Client was able to see all "members", which includes members that are 'incomplete (usp)'. This is not the right count, where it should only be members that are approved.
Brief summary of the fix
Looked at the file - /core/components/com_members/site/controllers/profiles.php that generates the members data rows.
Then looked at the database table of jos_users. Below shows all the invalid members that we need to filter out, looking at what is common, there is sendEmail and email column.
Back at the file, added in some where filters to the entries.
where 'sendEmail' >= 0
where 'email' NOT LIKE '%invalid%'
The options of sendEmail are the following:
-1 - nothing has been selected, it's just the 'select an option'
0 - not opted in
1 - opted in for email
With the solution, members will only 585, which is the right count of active members:
In general, this solution would be ok with all clients / hubs.
Source JIRA card(s) and hubzero ticket(s)
https://cmkc.usp.org/support/ticket/36 https://sdx-sdsc.atlassian.net/browse/USP-168
Brief summary of the issue
Client was able to see all "members", which includes members that are 'incomplete (usp)'. This is not the right count, where it should only be members that are approved.
Brief summary of the fix
Looked at the file - /core/components/com_members/site/controllers/profiles.php that generates the members data rows.
Then looked at the database table of jos_users. Below shows all the invalid members that we need to filter out, looking at what is common, there is sendEmail and email column.
Back at the file, added in some where filters to the entries.
The options of sendEmail are the following:
With the solution, members will only 585, which is the right count of active members:
In general, this solution would be ok with all clients / hubs.
Brief summary of your testing
Tried the solution on stage.cmkc.hubzero.org/members and it shows the right count of members.
Do the change needs to be hotfixed to any production hubs before a normal core rollout
Yes, it needs to be released because client needs it for production. Client will showcase site to conference. Sooner the better, can we cherry pick?
Double check someone is assigned to review the ticket
Yes - Nick and David