hubzero / hubzero-cms

Platform for Scientific Collaboration
https://hubzero.org
GNU General Public License v2.0
47 stars 57 forks source link

[CMKC] Fix for Forum Reply Post not showing ckeditor Controls #1718

Closed jessewoo closed 3 months ago

jessewoo commented 3 months ago

Source JIRA card(s) and hubzero ticket(s)

https://sdx-sdsc.atlassian.net/browse/USP-182

Brief summary of the issue

Replying to a forum post doesn't show the ckeditor controls

Brief summary of the fix

CSS was hiding elements. Hidden elements didn't allow ckeditor JS to select the specific element it was looking for and wrap the editor controls. Even though the php code showed the method $this->editor(), without the span element, the JS couldn't wrap around any ckeditor code.

Fix was to specific what span element to hide, which I think the original intent was to hide the input labels. In the css, I added in specific class that the span label had.

Screenshots showing fix

Before showcasing the issue image

After the change image image

Brief summary of your testing

Tried it on https://woo.aws.hubzero.org and once accepted, can push to stage.cmkc then production, bundle with the members page.

Do the change needs to be hotfixed to any production hubs before a normal core rollout

Yes, it needs to be released because the client urgency wants it for the advisory board to do more edits. Sooner that we can cherry pick, the better.

Double check someone is assigned to review the ticket

Yes - Nick and David