huchenlei / stable-diffusion-ps-pea

Use Stable Diffusion in Photopea!
GNU General Public License v3.0
74 stars 3 forks source link

[Bug] Auto generation type selection broken #21

Closed huchenlei closed 1 year ago

huchenlei commented 1 year ago

The auto generation type selection is broken since the commit reference range is added.

The old conditioning was checking whether the captured image and masks are both solid color (i.e. all pixels are same color), but obviously the mask of the expanded area will be black while the selected area will be white, so the condition for txt2img is only satisfied when selecting the whole canvas, and the whole canvas is solid color.

After using the the feature for several weeks, I found that it is pretty annoying an unpredictable, as a single pixel in the selection can break the logic, leading to wrong generation type, thus I propose removing the Auto generation type feature.

huchenlei commented 1 year ago

Feature removed in https://github.com/huchenlei/stable-diffusion-ps-pea/commit/6d695651b788ab2e47bbbb1a1bc012ed50428edb.