hudamalmsteen / csipsimple_test

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Proximity sensor doesn't works on Motorola xt701 #181

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Since you guys have done such an AMAZING job helping me get pbxes working, i 
have decided to reward you with another issue :-P

Whenever I am using the app, and put the phone to my face, the touchscreen is 
still active.  This can cause any number of random effects, such as opening 
other apps, hanging up, and so on.

My phone has a front face sensor built into it that turns off the screen and 
touchscreen input when I am using the normal dialer.  Can you guys look into 
this issue and make it so that the touchscreen is disabled during calls?  Phone 
is Moto xt701 running android 2.1 update-1

Thanks!

PS, I have adopted you as my SIP App developers, if you need beta testing 
support, I would be happy to offer you whatever help I can.  I am also able to 
help some with the documentation when I have extra time, make sure you look at 
my last (and final) remark on my other issue.

Original issue reported on code.google.com by jerald...@gmail.com on 30 Aug 2010 at 7:29

GoogleCodeExporter commented 9 years ago
Ok interesting.

I've already implemented something with proximity sensor, but was a little bit 
naive and as for now works probably only with nexus one.

I have to see a little bit more in documentation to clean things.

I'll keep you in touch when something will be available to test on.

Original comment by r3gis...@gmail.com on 30 Aug 2010 at 7:59

GoogleCodeExporter commented 9 years ago
I can test any fixes on this device.  This might also make it work with any 
other devices that use the same hardware...

Original comment by jerald...@gmail.com on 30 Aug 2010 at 11:40

GoogleCodeExporter commented 9 years ago
New build -12-26 has a potential fix for this issue.
I reused code from the android source code (the one that aim to turn off screen 
when proximity sensor is detected).
That's not the way adopted by most opensource implementation of proximity 
sensor (they are all based on a value that is undocumented... I think one found 
it by experience and all copied the same - as I did for my nexus one). Let me 
know if my implementation works for you.
Just as reminder, correct behavior is *not* to turn off screen (it requires the 
use of a private API so I postponed that) but to display an "overlay" with a 
locker displayed that prevent from unwanted action with face.
Screen on/off is managed by the standard android powermanager then.

Original comment by r3gis...@gmail.com on 31 Aug 2010 at 7:20

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
sensor works with galaxy I9000, not only with nexus one. I will then test the 
-12-26 build, to see if something changed.

Original comment by m...@ufritz.de on 31 Aug 2010 at 6:25

GoogleCodeExporter commented 9 years ago
Yes you're right, thanks. 
Indeed, it should be regressed on all devices with a proximity sensor. 

Original comment by r3gis...@gmail.com on 31 Aug 2010 at 6:28

GoogleCodeExporter commented 9 years ago
I'll test this shortly and let you know how it goes.  I made one call but 
didn't test it properly (covering the sensor and trying to input stuff)...

Original comment by jerald...@gmail.com on 31 Aug 2010 at 6:35

GoogleCodeExporter commented 9 years ago
Works fine, confirmed by covering the sensors with my thumb and mashing the 
different areas of the screen.  I will reward you again with another bug once I 
get the hang of recording a log...  This is closed on my end, with a note that 
if you find time to implement a screen shut off feature, it will be perfect.

Once again thanks!  Amazing!  I'm e-mailing you guys beer once the physicists 
at CERN figure that out!

Original comment by jerald...@gmail.com on 1 Sep 2010 at 12:00

GoogleCodeExporter commented 9 years ago
Good news. 
Hopefully other devices has not changed the android implementation of the 
powermanager and has just ensure test passes with their device so my fix is 
probably good since based on the same implementation than the one of android 
core system.

If somebody find a regression on another device, just cry ;).

Original comment by r3gis...@gmail.com on 1 Sep 2010 at 7:56

GoogleCodeExporter commented 9 years ago
In 0.00.12-35 > proximity sensor now turn off screen if possible (device 
support it).

Original comment by r3gis...@gmail.com on 20 Sep 2010 at 6:46

GoogleCodeExporter commented 9 years ago
Wow, thanks!  You guys have saved me tons of cash on t-mobile minutes, I'll 
donate something as soon as I can!

Original comment by jerald...@gmail.com on 21 Sep 2010 at 11:59