huderlem / porymap

Map editor for pokeemerald, pokefirered, and pokeruby
https://huderlem.github.io/porymap/
GNU Lesser General Public License v3.0
464 stars 93 forks source link

Open / edit layouts with no associated map #182

Open GriffinRichards opened 4 years ago

GriffinRichards commented 4 years ago

At the moment, to open/edit layouts that don't have an associated map you have to create a dummy map, which clutters the project and is tedious to do for multiple layouts. The ability to open/edit these layouts without having to do so would be convenient

huderlem commented 4 years ago

I'm not sure what a good way to do this in the UI would be. When sorting the map list by layout, perhaps there could be a right-click option to open the layout in "map-only" mode. This would effectively disable the non-map tabs, but still allow editing and saving all things layout-related.

LOuroboros commented 3 years ago

I'm not sure what a good way to do this in the UI would be. When sorting the map list by layout, perhaps there could be a right-click option to open the layout in "map-only" mode. This would effectively disable the non-map tabs, but still allow editing and saving all things layout-related.

Is there a reason not to do that? :eyes:

gruxor commented 2 years ago

Big +1 to this. Just going by the instances of setmaplayoutindex in the scripts alone, there are 18 maps in Emerald that use alternate layouts. Notably Route 111, Mirage Island, and multiple (every layer?) layers of Sky Pillar. Instances like #417 seem to mean that there's more than just those, too.

There's essentially second versions of these maps that are entirely invisible/inaccessible in Porymap (other than the Layout View, in which they just show up as empty folders). So you currently have to create a map, copy your changes over from the main layout, manually replace the alternate layout with your new layout in the json (or overwrite the existing layout file in the filesystem), and then delete your extra leftover map data.

I might try to figure out how to implement something to handle this and PR it, but I've never used Qt or C++ (mainly C# and other interpreted languages, but I'm catching on to C pretty fast via pokeemerald). Would really love to see this become a feature one way or another though.

tustin2121 commented 2 years ago

Discussion in the discord on the layout issue: https://discord.com/channels/442462691542695948/495019188042203147/1015661854225338438

Summary: