hudl / HudlFfmpeg

Hudl.Ffmpeg framework
Apache License 2.0
112 stars 32 forks source link

Implement timeout functionality and process monitoring #81

Closed Casey-Bateman closed 7 years ago

Casey-Bateman commented 7 years ago

Implement a Mono and Windows based async process monitor.

This process monitor will let us add timeouts and standard error and out stderr and stdout monitoring. This opens the route for things like progress monitoring, and special event detection.

codecov-io commented 7 years ago

Current coverage is 69.75% (diff: 7.94%)

Merging #81 into master will decrease coverage by 2.11%

@@             master        #81   diff @@
==========================================
  Files           229        235     +6   
  Lines          4280       4410   +130   
  Methods        1354       1393    +39   
  Messages          0          0          
  Branches        367        386    +19   
==========================================
  Hits           3076       3076          
- Misses         1032       1162   +130   
  Partials        172        172          

Powered by Codecov. Last update 6e48964...1341443

ericwclymer commented 7 years ago

Nothing in here sticks out to me as problematic. Like I said in slack, I'm not comfortable giving an "approve" and being confident that things will work, but I did look it over and didn't have any comments.