search

hudl / fargo

Golang client for Netflix Eureka
MIT License
133 stars 53 forks source link

Allow for customizable instance IDs ... and a few fixes #25

Closed st3v closed 9 years ago

st3v commented 9 years ago

The main purpose of this PR is to add the ability to use custom instance IDs. This is needed in order to register multiple instances of the same app in a PAAS like Cloud Foundry. In such an environment the host name is the same for multiple instances of an app. Thus, using the host name as the instance ID will cause collisions in the registry. Beside the PAAS-case there are other use cases that require this feature, e.g. docker containers running on the same host.

This functionality has been added to the Java client a while ago, for details see https://github.com/Netflix/eureka/pull/85.

The rest of the commits in this PR were needed to (a) get the Vagrant boxes up and running and (b) have all tests pass.

Let me know if you've got any questions. Thanks!

itsrainy commented 9 years ago

Thanks for the contribution @st3v. This looks good to me.

@tysonstewart or @llaughlin could I get another set of eyes on this before I merge? It shouldn't affect our usage of fargo since we don't currently set the UniqueId() function anywhere.

ryansb commented 9 years ago

@jcox92 I'll take a look at this before the end of the week.

ryansb commented 9 years ago

Looks good to me, :100:

st3v commented 9 years ago

Thanks for merging this!

itsrainy commented 9 years ago

Definitely! Thanks for making fargo better!