search

hudl / fargo

Golang client for Netflix Eureka
MIT License
133 stars 53 forks source link

Allow use of custom http.Client #38

Closed st3v closed 8 years ago

st3v commented 8 years ago

Hi,

I would like to use fargo to access an OAuth-protected instance of Eureka. In order to do that I need a way to switch out the http.Client that is being used to send requests. This PR adds that functionality. It should not affect the current behavior. I added a unit test to verify the new behavior.

Let me know if you have questions or feedback.

Thanks!

st3v commented 8 years ago

Here's an example that shows how this can be used: https://gist.github.com/st3v/88ecb4b016377af6c8f258ed14ec7b4c

itsrainy commented 8 years ago

Thanks for contributing @st3v! Looks good at first glance. I'll get this reviewed and tested tomorrow.

st3v commented 8 years ago

@jcox92 Did you get a chance to review and test this?

asim commented 8 years ago

Any movement on this?

itsrainy commented 8 years ago

Apologies for the delay. I was just able to get this tested and it works as expected. I'll go ahead and merge