hudl / fargo

Golang client for Netflix Eureka
MIT License
133 stars 53 forks source link

Expose response HTTP status code in errors #52

Closed seh closed 8 years ago

seh commented 8 years ago

For various operations involving HTTP requests against the Eureka server, allow callers to interpret surfaced failures by way of inspecting the HTTP response's status code.

This proposal is a subset of the preceding #47, also intended to address #45. Rather than fargo interpreting what the server's responses mean in the context of the attempted operation, we leave that interpretation open to callers.

seh commented 8 years ago

I'm happy enough with it. I'm going to implement some of #47 on the caller side to see if any additional helper functions emerge that are worth sharing, but I understand your goal of keeping the surface area of fargo small.