search

hudl / fargo

Golang client for Netflix Eureka
MIT License
133 stars 53 forks source link

Schedule updates to the set of instances registered with a VIP address #55

Closed seh closed 7 years ago

seh commented 7 years ago

Per the preceding discussion in #53, and sitting on top of #54, poll the instances for a VIP address periodically. This implements the "consuming" capability mentioned in #53, with a contraction in the method names down to EurekaConnection.ScheduleVIPAddressUpdates and EurekaConnection.ScheduleSecureVIPAddressUpdates, not mentioning the word "instance" there.

I used the same "functional options" technique first appearing in #54 for the following options that one can supply to GetInstancesByVIPAddress, GetInstancesBySecureVIPAddress, ScheduleVIPAddressUpdates, and ScheduleSecureVIPAddressUpdates:

I intend to apply those options to the "caching" factory functions as well.

damtur commented 7 years ago

When you address comments in #54 This LGTM. Great job, good tests as well.