Add JSON support: - Githubissues

hudl / fargo

Golang client for Netflix Eureka

MIT License

133 stars 53 forks source link

Add JSON support: #6

Closed cquinn closed 10 years ago

cquinn commented 10 years ago

rpc extensions to support both XML and JSON requests and responses
net support for a Eureka connection using JSON or XML
net support for marshalling and unmarshalling of the apps, app and instance structs
custom unmarshallers and intermediate wrapper structs to deal with nasty Eureka JSON
updated existing net tests to test both XML and JSON
added new sample-driven tests for JSON unmarshalling. (tricky to get that working--tests were a lifesaver)

cquinn commented 10 years ago

We have a need at our company (Riot Games) to use the JSON flavor of Eureka's REST API. This pull request adds that support to fargo in an optional way. I've made a few other changes that I'll comment on inline.

Let me know if you are interested in this change in general, and I'll make sure that I've cleaned up anything you don't like. There are definitely some debug / comment bits in there that need some cleanup before committing.

ryansb commented 10 years ago

I'd definitely be interested in this. Most of the reason there isn't JSON support already is the gotchas in the Eureka JSON API.

I've made some comments, but this is definitely worth working on. Thanks a ton for your contributions.

cquinn commented 10 years ago

OK, I think I've addressed all your comments.

ryansb commented 10 years ago

Looks great. Just a couple nitpicks then I'll merge it and tag a new release.

cquinn commented 10 years ago

I think all your comments are addressed now.

ryansb commented 10 years ago

Great, thanks!