search

hudl / fargo

Golang client for Netflix Eureka
MIT License
133 stars 53 forks source link

Make server application context variable for DNS discovery #65

Closed semyonslepov closed 6 years ago

semyonslepov commented 7 years ago

Right now server application context for DNS ServiceURLs discovery is hardcoded to eureka/v2 while it could be set to a different value on the server side. This simple patch makes it configurable.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

semyonslepov commented 7 years ago

Changed variable names for URL base to less ambiguous. As the empty URL is not possible for Eureka it's safe to make eureka/v2 default value for this base. @seh

semyonslepov commented 6 years ago

Is there anything else to change before the final approval and merge?

@seh @ryansb @damtur

seh commented 6 years ago

Sorry, but I don’t have permission to merge PRs in this repository. I can review and approve then, but not merge them.

For what it’s worth, again, I think we should merge this.

damtur commented 6 years ago

I'm working on getting that merged.

damtur commented 6 years ago

I have not found any issues with this merging. Thank you very much for contribution @semyonslepov and thank you @seh for great comments.