search

hudochenkov / postcss-sorting

PostCSS plugin to keep rules and at-rules content in order.
MIT License
516 stars 30 forks source link

at-variables config for Less #80

Closed DarkPreacher closed 6 years ago

hudochenkov commented 6 years ago

Thank you for your PR.

I see linting errors in Travis. I must have skipped precommit hook. Please run npm run fix to fix lint error. It will reformat files. It's ok.

Tests are missing. Please, add new keyword to https://github.com/hudochenkov/postcss-sorting/blob/3e0e8191699069866628458ad26c6483e363fc0a/lib/order/__tests__/order.js#L29

And add test cases to keywords.css (it's an input) and keywords.expected.css (it's an expected output after running plugin with options defined in __tests__/order.js).

DarkPreacher commented 6 years ago

I've did npm run fix — it didn't change anything, Keyword to __tests__/order.js I've added before, but missed test cases — fixed.

hudochenkov commented 6 years ago

I've did npm run fix — it didn't change anything,

Weird. Just run it in your repository and it did change files. Could you try to delete node_modules and reinstall them, please? If it won't work, then I'll commit fix in your repository.

DarkPreacher commented 6 years ago

Had to run npm run fix under Ubuntu in VM, worked fine. Have no idea why it don't do anything under Win10 with Node 9.

hudochenkov commented 6 years ago

Thank you!