search

hudon / spike

Brain Simulator Parallelization
http://nengo.ca/
1 stars 1 forks source link

Fix the warning that complains about the use of OrderedDict. #33

Closed RobertElder closed 11 years ago

hudon commented 11 years ago

I don't know if we can use this... there must be a reason why the Nengo guys are using this data structure?

RobertElder commented 11 years ago

In the new code they no longer use a regular dictionary, and use an OrderedDict instead. I think the use of a regular dictionary was a copied artifact of our prototype that we got working with the old theano code, for the make_tick function. I'm guessing the reason they switched to using OrderedDict was also to get rid of the warnings.

hudon commented 11 years ago

if the tests still pass, +1

RobertElder commented 11 years ago

I tested on my machine after deleting ~/.theano a few times, and re-starting my computer, and the tests still pass (After running them continuously for about 15 minutes). If you don't mind, I'd like you to checkout this branch and make sure they pass to. I want to be sure zeromq is not caching some random thing or something. On Tuesday when I noticed that everything was broken on every branch, it was around the time I started experimenting with trying to get rid of this warning, but I'm not sure if the problem happened before or after I experimented with this change. I have not been able to re-produce the errors I saw that day.

hudon commented 11 years ago 
hudon@pilgrim:~/Code/spike$ make test
/bin/bash test/run-tests.sh
Computing output from command '/usr/bin/python2 /home/hudon/Code/spike/test/nengo_tests/test_array.py    /home/hudon/Code/spike/test/../src target'...Took 39 seconds.
Computing output from command '/usr/bin/python2  /home/hudon/Code/spike/test/nengo_tests/test_array.py    /home/hudon/Code/spike/test/../examples/new-theano'...Took 11 seconds.
INFO: All Tests Passed.
Computing output from command '/usr/bin/python2 /home/hudon/Code/spike/test/nengo_tests/test_radius.py    /home/hudon/Code/spike/test/../src target'...Took 44 seconds.
Computing output from command '/usr/bin/python2  /home/hudon/Code/spike/test/nengo_tests/test_radius.py    /home/hudon/Code/spike/test/../examples/new-theano'...Took 13 seconds.
INFO: All Tests Passed.
Computing output from command '/usr/bin/python2 /home/hudon/Code/spike/test/nengo_tests/test_enc.py    /home/hudon/Code/spike/test/../src target'...Took 23 seconds.
Computing output from command '/usr/bin/python2  /home/hudon/Code/spike/test/nengo_tests/test_enc.py    /home/hudon/Code/spike/test/../examples/new-theano'...Took 10 seconds.
INFO: All Tests Passed.

looks good to me!