search

hudson-and-thames / mlfinlab

MlFinLab helps portfolio managers and traders who want to leverage the power of machine learning by providing reproducible, interpretable, and easy to use tools.
Other
3.95k stars 1.15k forks source link

there is a typo #427

Closed zhangyw49 closed 4 years ago

zhangyw49 commented 4 years ago

https://github.com/hudson-and-thames/mlfinlab/blob/8202463b669cbd6b20a6a75a649bdc5e9c8cb5b3/mlfinlab/portfolio_optimization/mean_variance.py#L178

zhangyw49 commented 4 years ago

line 185 print("Portfolio Sharpe Ratio = %s" % self.portfolio_risk)

aditya1702 commented 4 years ago

@zhangyw49 Thank you for spotting this. Pushing a fix asap.

PanPip commented 4 years ago

@zhangyw49 Thank you for reporting this issue! 🙂

It is now fixed in PR #426. Soon it will be pushed to the master branch.