search

huertatipografica / Alegreya

Serif family, part of the Alegreya "super family" www.huertatipografica.com
SIL Open Font License 1.1
162 stars 11 forks source link

v2000: Gf mastering r02 #8

Closed m4rc1e closed 7 years ago

m4rc1e commented 7 years ago

So I've renamed NULL to uni0000 and regenned the fonts. It works as expected.

Before I release, I did spot these:

screen shot 2017-09-07 at 15 57 35

SC screen shot 2017-09-07 at 16 22 25 Disable this feautre or reimplement the old FI glyph.

Merge these then fix please.

juandelperal commented 7 years ago

Great! Will fix

2017-09-07 12:26 GMT-03:00 Marc Foley notifications@github.com:

So I've renamed NULL to uni0000 and regenned the fonts. It works as expected.

Before I release, I did spot these:

[image: screen shot 2017-09-07 at 15 57 35] https://user-images.githubusercontent.com/7525512/30170959-7588d5c6-93e8-11e7-891c-d08c432bceb9.png

SC [image: screen shot 2017-09-07 at 16 22 25] https://user-images.githubusercontent.com/7525512/30171086-cb8bf250-93e8-11e7-8622-545cc40f0c75.png Disable this feautre or reimplement the old FI glyph.

Merge these then fix please.

You can view, comment on, or merge this pull request online at:

https://github.com/huertatipografica/Alegreya/pull/8 Commit Summary

  • renamed glyph NULL --> uni0000
  • regenerated fonts. Added eot fonts

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/huertatipografica/Alegreya/pull/8, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTZfEW_tRmbzFE5laFl5ec2h5PP8cqZks5sgAsigaJpZM4PP_U7 .

juandelperal commented 7 years ago

Thanks @m4rc1e for pointing this. I found a similar bug also in Alegreya Sans: screen shot 2017-09-08 at 3 10 39 pm Now is fixed in both families. I tagged a new version screen shot 2017-09-08 at 4 21 40 pm

Can we PR this to https://github.com/google/fonts/? Thank you