search

huertatipografica / Andada-Pro

Andada is a text font with an organic-slab serif, hybrid style, a solid design of medium stroke contrast.
SIL Open Font License 1.1
27 stars 4 forks source link

Vertical regression #9

Closed RosaWagner closed 3 years ago

RosaWagner commented 3 years ago

We can't serve an update which has different vertical metrics from previous published version. It would mess up too much webpages.

We also needtypoLinegap = hheaLineGap = 0.

Previous: Capture d’écran 2021-04-27 à 16 29 17

New: Capture d’écran 2021-04-27 à 16 28 46

Current diff: Desktop_Windows_10_edge_18 0_

CaroGiovagnoli commented 3 years ago

How can I get your version to compare with my version? It's difficult to see with this animated gif in detail. Thanks, Caro

RosaWagner commented 3 years ago

I updated the screenshot of v-matrics values, I had put 2 times the same.

I am comparing the version published on google fonts: https://fonts.google.com/specimen/Andada with your actual version that is in the PR #11

CaroGiovagnoli commented 3 years ago

The metrics and the weights are different now. The new regular and bold are lighter and there are more weights available, I've had added intermediate weights, Medium, and ExtraBold.

I think that given that this won’t be 100% backward compatible, then it’s better to fix the vertical metrics now. Better to break things for better just once :)

RosaWagner commented 3 years ago

I know this is annoying, but there are reasons for these specifications. The first one is that Andada is served to several thousands of websites, and we can't break thousands of websites without upsetting as many web designers and developers.

Also, LineGap is not supported consistently across platform. Some applications are adding this space under the descender, some don't add this space at all. Web browsers share this space above the ascender, and under the descender. We need linegap value to 0 to ensure consistent start baseline and linespacing in different environments.

Good news is, WinAscent and WinDescent are used to match Y-max and Y-min to avoid text clipping, and since we activate the use_typo_metric flags, it is okay for those value to change.