Controller session - Githubissues

huesitos / effdy

Application that makes studying concepts with flashcards more effective.

GNU General Public License v2.0

6 stars 6 forks source link

Controller session #19

Closed huesitos closed 9 years ago

huesitos commented 9 years ago

Test:

create
- with existing user
- with non-existing user
destroy

gotjosh commented 9 years ago

Hey there! I'm about to start working on this one, is it ok if I do some refactoring along the way?

huesitos commented 9 years ago

Hello! Sure! Although, there is a weird bug that appeared when testing Topic, and Card model. So, I don't know if this one will work.

gotjosh commented 9 years ago

@huesitos right now the app allows you the log in via Facebook, Twitter and Google. Could you please create sandbox applications in each platform in order to leave those as "defaults" so that the app just works out of the box. Some of the providers (such as Facebook) even allow you to specify that the app you're creating is a test version of another one.

huesitos commented 9 years ago

@gotjosh I don't want to commit the omniauth file with the sandbox apps' keys embedded in it. If I list them in the readme file, would that be good for you?

gotjosh commented 9 years ago

For me, it makes no difference. The idea behind it is that whenever someone wants to work on the app or contribute, they don't have to go through the process of having to create these apps in the corresponding Platform, it can very tedious specially if you don't have an account for that specific platform.