search

huesitos / effdy

Application that makes studying concepts with flashcards more effective.
GNU General Public License v2.0
6 stars 6 forks source link

Add CI #35

Closed gotjosh closed 9 years ago

gotjosh commented 9 years ago

One way to guarantee integrity of the project is to have a CI platform (such as travis or CodeShip) post back to Github in order to know if the Pull Request or Commit passed the tests, this is important for open source projects where other users which might not know all the details of an application could make breaking changes.

I suggest you add these ASAP in order to minimize Regressions.

EDIT: I forgot to mention that both platforms are free for Open Source projects.

huesitos commented 9 years ago

There is one: https://travis-ci.org/huesitos/aplus We just haven't finished the tests yet, so it'll be failing till we finish them. But there is this issue https://github.com/huesitos/aplus/issues/34, that we don't know how to solve yet.

gotjosh commented 9 years ago

Could you please integrate it with github so that it reports back via the Pull Requests?

huesitos commented 9 years ago

I think it does now. Isn’t the x next to the pull-requests signalling it failed CI tests in https://github.com/huesitos/aplus/pulls?q=is%3Apr+is%3Aclosed? If not, how do I do that?

huesitos commented 9 years ago

Like I said in the previous comment, this is already done. I'm closing it.