search

huff-language / huffmate

A library of modern, hyper-optimized, and extensible Huff contracts with extensive testing and documentation built by Huff maintainers.
https://github.com/pentagonxyz/huffmate
MIT License
430 stars 55 forks source link

issue: ERC20 decimals should be uint8 #95

Closed eugenioclrc closed 1 year ago

eugenioclrc commented 1 year ago

According to ERC20 especification the decimals shoud be defined as;

function decimals() public view returns (uint8)

But in ERC20.huff#L29 this is the definition;

#define function decimals() nonpayable returns (uint256)

Shouldnt be this definition?

#define function decimals() nonpayable returns (uint8)
Maddiaa0 commented 1 year ago

Good spot, we will get that fixed, thank you!

eugenioclrc commented 1 year ago

Submit this pull request with a proposed fix; https://github.com/pentagonxyz/huffmate/pull/105

Maddiaa0 commented 1 year ago

Thank you!