search

hugeblank / allium

Lua script loader and API for easy Minecraft modding
MIT License
41 stars 8 forks source link

Fix Modrinth download badge #38

Closed triphora closed 1 year ago

triphora commented 1 year ago

v1 of Modrinth's API has been deprecated since January 2022 and is scheduled to begin breaking in February, with a complete breakage being done by March. This pull request has been created as a courtesy to update it to use the dedicated shields.io badge rather than manually constructing the API request.

After merging this PR, please also update any usages on other pages, for example a CurseForge and/or Modrinth project description, and also cherry-pick/copy these changes to any other branches you might have.

P.S. Allium isn't on Modrinth at all anymore so I guess the badge doesn't work even with this fix... what's up with that?

triphora commented 1 year ago

@hugeblank Please make sure you merge this before the March 14th deadline.

hugeblank commented 1 year ago

Allium isn't on Modrinth at all anymore so I guess the badge doesn't work even with this fix... what's up with that?

It actually never has been because it's not release ready. I preemptively put the badge there because I know would have forgotten to at the time of publishing.