Closed aroundabout closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@Radeity could also take a look for it when free, THX
test review for check comment pending label
[image: image.png] It seems to have a pending label, maybe it is invisible to you? Aaron Wang @.> 于2023年9月1日周五 15:24写道: … @*.* commented on this pull request. ------------------------------ In .github/workflows/publish_latest_server_image.yml <#1 (comment)>: > + schedule: + - cron: '0 23 ' Hi @aroundabout https://github.com/aroundabout , may I ask why you mark this comment as resolved without any comment? Just some humble suggestion, feel free to express different opinion :D — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL2ZYVH6SHJU2KFUR6E5ILLXYGERLANCNFSM6AAAAAA3IBHZKY . You are receiving this because you were mentioned.Message ID: *@*.***>
I can not see the pending msg. And in this reply, this image.png is also invisible.
I will ask the admin for help
Aaron Wang @.***> 于 2023年9月1日周五 下午5:07写道:
[image: image.png] It seems to have a pending label, maybe it is invisible to you? Aaron Wang @.
*> 于2023年9月1日周五 15:24写道: … <#m-7535884572093133655> @.** commented on this pull request. ------------------------------ In .github/workflows/publish_latest_server_image.yml <#1 (comment) https://github.com/hugegraph/actions/pull/1#discussion_r1312668801>: >
- schedule: + - cron: '0 23 *' Hi @aroundabout https://github.com/aroundabout https://github.com/aroundabout https://github.com/aroundabout , may I ask why you mark this comment as resolved without any comment? Just some humble suggestion, feel free to express different opinion :D — Reply to this email directly, view it on GitHub <#1 (comment) https://github.com/hugegraph/actions/pull/1#discussion_r1312668801>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL2ZYVH6SHJU2KFUR6E5ILLXYGERLANCNFSM6AAAAAA3IBHZKY https://github.com/notifications/unsubscribe-auth/AL2ZYVH6SHJU2KFUR6E5ILLXYGERLANCNFSM6AAAAAA3IBHZKY . You are receiving this because you were mentioned.Message ID: @.***>
I can not see the pending msg. And also in this reply, this image.png is also invisible. [image: image] https://user-images.githubusercontent.com/45198818/264977371-9fd4c950-3bc0-4b6e-9492-0452bd1152c0.png
— Reply to this email directly, view it on GitHub https://github.com/hugegraph/actions/pull/1#issuecomment-1702422047, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL2ZYVBNGNWNX3PKBGJHCYDXYGQWTANCNFSM6AAAAAA3IBHZKY . You are receiving this because you were mentioned.Message ID: @.***>
Purpose of PR
subtask of https://github.com/apache/incubator-hugegraph/issues/840
Main change
Api reference: This api help us to update the github repo var Update a repository variable
old desgin doc: https://github.com/apache/incubator-hugegraph/issues/2254 new design doc: extra design doc
new change
Before Merge
Create a branch in apache/hugegraph repo, then I can submit a pr of the release-1.0.0 with correct dockerfile and other shell. it needs the admin to create.
Before merge, admin should confirm that there are the repository secrets "DOCKERHUB_PASSWORD", "DOCKERHUB_USERNAME", "PAT" are provided, where "PAT" is a token accessible to the repo.
Repository variables "LATEST_SHA" should be provided. Because there is no "create an update" api, "LATEST_SHA" are necessary.