hugeinc / styleguide

A tool to make creating and maintaining style guides easy.
http://hugeinc.github.io/styleguide
MIT License
1.87k stars 170 forks source link

If harp is not installed, it does not raise any errors #32

Closed gabrielpugliese-luizalabs closed 9 years ago

gabrielpugliese-luizalabs commented 9 years ago

It would be nice to raise an error or something, because I just skipped that part and didn't know why it was not working :)

caiovaccaro commented 9 years ago

Hey @gabrielpugliese-luizalabs ! By skipped, what do you mean exactly? You have used the Start.app or the manual installation process?

Thanks!

gabrielpugliese-luizalabs commented 9 years ago

It's the manual process. I haven't noticed that there is an Start.app command (haven't found it yet - where is it located?)

caiovaccaro commented 9 years ago

What is your operating system, windows?

On Monday, August 10, 2015, gabrielpugliese-luizalabs < notifications@github.com> wrote:

It's the manual process. I haven't noticed that there is an Start.app command (haven't found it yet - where is it located?)

— Reply to this email directly or view it on GitHub https://github.com/hugeinc/styleguide/issues/32#issuecomment-129637835.

gabrielpugliese-luizalabs commented 9 years ago

Ubuntu 14.04

caiovaccaro commented 9 years ago

Ok! Nice, can you just write your steps so I can reproduce?

Something like:

Etc. And I will add a error message for missing dependencies when starting the server.

gabrielpugliese-luizalabs commented 9 years ago

Ok

  1. I've downloaded the bundle and unzipped
  2. cd styleguide/structure/_node-files && npm install
  3. node watch.js

The progress is 100% but nothing is being served because harpjs is not installed.

gabrielpugliese-luizalabs commented 9 years ago

I would add a command before 2. in the steps like: npm install -g harp and also check if harp is installed on the startup of watch.js

caiovaccaro commented 9 years ago

Perfect, I'll do that and it will be release on version 2.0.5.

Thank you!

gabrielpugliese-luizalabs commented 9 years ago

:rocket:

caiovaccaro commented 9 years ago

Closed on develop, soon to be merged.

https://github.com/hugeinc/styleguide/blob/develop/styleguide/structure/_node-files/watch.js