hugelgupf / p9

Idiomatic Go 9P2000.L client and server, extracted from gVisor for general use
Apache License 2.0
90 stars 19 forks source link

Use existing `ulog`s rather than global std `log` #83

Closed hugelgupf closed 1 year ago

hugelgupf commented 1 year ago

Server and Client have a default value for their log, which can be overridden by callers of their constructors. If none are provided, nothing should be printed, if one is, it should be used for these messages, rather than using the global log.

clientFile does not need to log a failure from Close at all, the caller will receive the error value directly, and the context added to the message, is already implied by the protocol.