huggingface / Google-Cloud-Containers

Hugging Face Deep Learning Containers (DLCs) for Google Cloud
https://hf.co/docs/google-cloud
Apache License 2.0
131 stars 18 forks source link

Revert `ingressClassName` over `annotation` #108

Closed alvarobartt closed 1 month ago

alvarobartt commented 1 month ago

Description

This PR reverts the PR #107, since even though it's deprecated in Kubernetes; it needs to be specified via the annotations for it to work on Google Kubernetes Engine (GKE).

Now a note has been included so that the DeprecationWarning is ignored.

More information at https://cloud.google.com/kubernetes-engine/docs/concepts/ingress