huggingface / accelerate

🚀 A simple way to launch, train, and use PyTorch models on almost any device and distributed configuration, automatic mixed precision (including fp8), and easy-to-configure FSDP and DeepSpeed support
https://huggingface.co/docs/accelerate
Apache License 2.0
7.32k stars 872 forks source link

typo in examples/slurm/submit_multinode.sh script #2881

Closed hubutui closed 1 week ago

hubutui commented 1 week ago

System Info

None

Information

Tasks

Reproduction

https://github.com/huggingface/accelerate/blob/1f7a79b428749f45187ec69485f2c966fe21926e/examples/slurm/submit_multinode.sh#L40

Expected behavior

https://github.com/huggingface/accelerate/blob/1f7a79b428749f45187ec69485f2c966fe21926e/examples/slurm/submit_multinode.sh#L40 should be:

export CMD="$LAUNCHER $SCRIPT $SCRIPT_ARGS"
BenjaminBossan commented 1 week ago

Indeed, thanks for reporting. Do you want to create a PR to fix this?

hubutui commented 1 week ago

thanks, and no.