search

huggingface / autotrain-advanced

🤗 AutoTrain Advanced
https://huggingface.co/autotrain
Apache License 2.0
3.84k stars 472 forks source link

parse configs #614

Closed abhishekkrthakur closed 5 months ago

HuggingFaceDocBuilderDev commented 5 months ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

adubovik commented 5 months ago

@abhishekkrthakur Hi, this change:

https://github.com/huggingface/autotrain-advanced/pull/614/files#diff-2f47c23122ba39298a8d6243f20cc82e153896067b90440b97ad3dcf31cc986dR80-R82

        if _params["quantization"] == "none":
            _params["quantization"] = None

made the quantization config parameter required. It throws KeyError when it's missing.

Is it intended? Should it be something like this?

        if _params.get("quantization") in ["none", None]:
            _params["quantization"] = None
abhishekkrthakur commented 5 months ago

yes. its only used for ui. cli remains unaffected.

adubovik commented 5 months ago

Right. I noticed it, because I wasn't able to use training parameters for UI you provided in the tutorial as is. Maybe it's worth to update the article.

Also, there is a typo in the training split name. It should be called train istead of train_sft.