huggingface / blog

Public repo for HF blog posts
https://hf.co/blog
2.39k stars 754 forks source link

Super tiny fix typo: warmup ratio reported in numina #2465

Open fzyzcjy opened 2 weeks ago

fzyzcjy commented 2 weeks ago

Hi thanks for the blog! When looking at source code, it seems that:

But the blog mentions both as 0.1. Thus I guess it may potentially be a very little typo and make this PR.

Please correct me if I am wrong! For example, maybe my understanding of the config is incorrect.


Congratulations! You've made it this far! Once merged, the article will appear at https://huggingface.co/blog. Official articles require additional reviews. Alternatively, you can write a community article following the process here.

Preparing the Article

You're not quite done yet, though. Please make sure to follow this process (as documented here):

Here is an example of a complete PR: https://github.com/huggingface/blog/pull/2382

Getting a Review

Please make sure to get a review from someone on your team or a co-author. Once this is done and once all the steps above are completed, you should be able to merge. There is no need for additional reviews if you and your co-authors are happy and meet all of the above.

Feel free to add @pcuenca as a reviewer if you want a final check. Keep in mind he'll be biased toward light reviews (e.g., check for proper metadata) rather than content reviews unless explicitly asked.