huggingface / candle

Minimalist ML framework for Rust

Apache License 2.0

14.99k stars 874 forks source link

`gradient_accumulation_steps` b2b #2342

Closed Khaliq88 closed 1 month ago

Khaliq88 commented 1 month ago

          We can add a check in more than one place. Although, tbh, I've never seen someone raise an issue because of setting `gradient_accumulation_steps` to be less than 1 so I don't think this is something we really need to address.

_Originally posted by @amyeroberts in https://github.com/huggingface/transformers/pull/32020#discussion_r1683019529_

Khaliq88 commented 1 month ago

2341

1469

amyeroberts commented 1 month ago

@Khaliq88 Please refrain from spamming the issues with copies of comments from reviews and other issues and linking to things which are unrelated.