search

huggingface / chat-ui

Open source codebase powering the HuggingChat app
https://huggingface.co/chat
Apache License 2.0
7.31k stars 1.06k forks source link

A few questions about the Cloudflare integration #1220

Closed kodster28 closed 3 months ago

kodster28 commented 4 months ago

Howdy 👋 ,

Working on a corresponding page for this in the Cloudflare docs and had a few questions that I need answered in this PR.

Questions

  1. If I'm reading this line correctly, it sounds like their example is actually incorrect and might need to be updated?
  2. If ^^^ is correct, does that mean that we should also be specifying the model parameter w/in the endpoint configuration?
  3. Correct assumption that this only works with models prefixed with @hf, think so based on their code.

Mind helping me out so I can get this live in our docs?

nsarrazin commented 4 months ago

Hey! Thanks for taking a look at this.

  1. Yes our example is incorrect, will update the docs to fix it
  2. No need, model is passed from inside chat-ui so it's all good.
  3. Yes I think so for now, though it could be made configurable if we want! (and if the APIs are compatible, not sure how it works cloudflare side)
kodster28 commented 4 months ago

Hey! Thanks for taking a look at this.

  1. Yes our example is incorrect, will update the docs to fix it
  2. No need, model is passed from inside chat-ui so it's all good.
  3. Yes I think so for now, though it could be made configurable if we want! (and if the APIs are compatible, not sure how it works cloudflare side)

Thanks @nsarrazin, happy to close out this issue or let you do it as this has answered my questions. I'll bring up 3 with the PM.

kodster28 commented 4 months ago

Related #1226