Closed nsarrazin closed 1 month ago
Overall this should be good to go @gary149, the feature is fully hidden behind a feature flag so we can deploy & test internally for now
First round of review on UX:
filter by name
is not working. For example, you can go to URL http://localhost:5173/chat/tools?sort=trending&q=parser where I expect the tools that only have substring parser
in their name to be present. But all the tools are present.
On medium sized screen, tool titles that are long like Image Generation
get cut
There should be limit on tool name and tool description
when a space does not have a function that can be called as a tool, we should show a label that says: Space does not have a callable function
. Example you can try with is: predatortoabuse/Realistic-Image-Generator-Model
durin toolmcreation, save btn should be disabled until all the fields are valid (i.e. have values)
I can enter string
into float
values. I guess we should not ?
cancel
btn in tools should go back to previous page. Right now, it is redirecting to homepage
Overall I think I should improve the inputs in the tool creation form. Use number input fields for Int
and Float
types, a checkbox for boolean
types and a radio with a list of options for Literal['optionA', 'optionB']
types. That should cover 99% of input types. Will tackle this
@mishig25 I implemented your feedback, should be better now!
I also refactored the input selection field for default values, it now only accepts floats for float inputs, integers for int inputs, shows a checkbox for boolean selection and a dropdown select for Literal
types with multiple choices
Going to merge this, since we have feature flags so it will be invisible to everyone and I can ensure everything is working well in prod.
Community tools
Features
/tools
page with list of toolsScreenshots
Main window
/tools
page/tools/[toolId]
pageNew tool/ tool edit form