search

huggingface / controlnet_aux

Apache License 2.0
398 stars 86 forks source link

Use opencv-python-headless over opencv-python #59

Open aknoerig opened 1 year ago

aknoerig commented 1 year ago

The install currently depends on opencv-python. Unfortuntately, this causes issues when deploying the package in the context of a headless server. Instead, just make it dependent on opencv-python-headless, as there is no need for a GUI here.

twowheels-code commented 1 year ago

I'd support this too. opencv-python-headless is enough for the functionality used here. especially in containered environments the opencv-python package fails to install due to binary dependencies for the GUI

patrickvonplaten commented 1 year ago

That would work for me - could someone open a PR maybe? :-)

jeanineharb commented 4 months ago

Issue fixed, it seems! https://github.com/huggingface/controlnet_aux/blob/master/setup.py#L85