huggingface / controlnet_aux

Apache License 2.0
400 stars 86 forks source link

matplotlib not installed in setup.py #74

Open LWprogramming opened 1 year ago

LWprogramming commented 1 year ago

matplotlib exists in _deps but not in install_requires and extras is empty. Is this intentional? Had to install this by hand in my venv and was kinda surprised

patrickvonplaten commented 1 year ago

Yeah that's probably a typo we could remove matplotlib from the deps list

LWprogramming commented 1 year ago

Ah hmm, I just double-checked the codebase and it looks like it does need it in some files (not just wrapping a numpy call or something)

Checked the two and matplotlib is the only one in _deps that's missing so I'll just add it